Lg-14277 verification data analytics event#11509
Merged
AShukla-GSA merged 16 commits intomainfrom Nov 27, 2024
Merged
Conversation
amirbey
reviewed
Nov 15, 2024
amirbey
reviewed
Nov 15, 2024
amirbey
reviewed
Nov 15, 2024
amirbey
reviewed
Nov 15, 2024
amirbey
reviewed
Nov 15, 2024
amirbey
reviewed
Nov 15, 2024
amirbey
reviewed
Nov 19, 2024
amirbey
reviewed
Nov 19, 2024
amirbey
reviewed
Nov 19, 2024
amirbey
reviewed
Nov 19, 2024
amirbey
reviewed
Nov 19, 2024
amirbey
reviewed
Nov 19, 2024
amirbey
reviewed
Nov 19, 2024
amirbey
reviewed
Nov 19, 2024
amirbey
reviewed
Nov 19, 2024
amirbey
reviewed
Nov 19, 2024
amirbey
reviewed
Nov 19, 2024
amirbey
reviewed
Nov 19, 2024
amirbey
reviewed
Nov 19, 2024
amirbey
reviewed
Nov 19, 2024
amirbey
reviewed
Nov 19, 2024
amirbey
reviewed
Nov 19, 2024
spec/services/doc_auth/socure/requests/docv_result_request_spec.rb
Outdated
Show resolved
Hide resolved
Contributor
|
hi, do you mind rebasing your branch? there were some changes to reviewapps that are making this PR not run properly in the reviewapp environment |
Contributor
|
it also seems like you may have 2 copies of reviewapps running for this PR, let me know when you do finish rebasing so i can just go in and clean those up |
solipet
reviewed
Nov 22, 2024
Contributor
solipet
left a comment
solipet
left a comment
There was a problem hiding this comment.
Looking great! A few small comments.
amirbey
reviewed
Nov 22, 2024
AShukla-GSA
force-pushed
the
lg-14277-verification-data-analytics-event
branch
from
021a8fc to
215f44a
Compare
amirbey
reviewed
Nov 26, 2024
amirbey
reviewed
Nov 26, 2024
AShukla-GSA
force-pushed
the
lg-14277-verification-data-analytics-event
branch
from
7e7eb6e to
8b23a73
Compare
amirbey
approved these changes
Nov 27, 2024
AShukla-GSA
force-pushed
the
lg-14277-verification-data-analytics-event
branch
from
8b23a73 to
1c17789
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-14277
🛠 Summary of changes
Logging socure request and response metrics described in ticket.