Fix HTML escaping for partner email sharing#11491
Merged
Conversation
changelog: Upcoming Features, Partner Email Selection, Fix HTML escaping for partner email sharing
646435c to
2ce0dda
Compare
zachmargolis
approved these changes
Nov 12, 2024
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Contributor
Author
|
I added a custom Rubocop linter in 563fa02, since it seems easy enough to flag calls to I had to limit this to apply only to views for now, since there's a lot of false positives in the backend Ruby code, particularly for error messages that are created with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Fixes an issue where partner email selection text was showing as escaped HTML.
The content was recently updated in #11468 to add HTML, and while the string key is correctly suffixed with
_html, one of two views usesI18n.tinstead oft, which does not perform automatic unescaping (docs).📜 Testing Plan
Verify the text does not show escaped HTML:
👀 Screenshots