LG-14905: socure webhook analytics event updates#11490
Merged
Conversation
amirbey
force-pushed
the
amirbey/LG-14905-socure-webhook-events-update
branch
from
a883e89 to
3459e53
Compare
amirbey
changed the title
solipet
approved these changes
Nov 12, 2024
Contributor
solipet
left a comment
solipet
left a comment
There was a problem hiding this comment.
A few suggestions, but greatly improved!
Contributor
There was a problem hiding this comment.
This spec seems out of place. Maybe move to
- with a valid webhook key (existing context)
- when event is missing (new context)
Comment on lines
82
to
83
Contributor
There was a problem hiding this comment.
If we're going to use the compact form, let's use it whenever we can.
Suggested change
| event_type:, | |
| reference_id: reference_id, | |
| event_type:, | |
| reference_id:, |
Contributor
There was a problem hiding this comment.
Suggested change
| reference_id: reference_id, | |
| reference_id:, |
Contributor
There was a problem hiding this comment.
Suggested change
| reference_id: reference_id, | |
| reference_id:, |
changelog: Upcoming Features, Document Authentication, Socure webhook event attribute updates
amirbey
force-pushed
the
amirbey/LG-14905-socure-webhook-events-update
branch
from
eda4677 to
f748595
Compare
amirbey
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-14905
🛠 Summary of changes
📜 Testing Plan