Lg 14790 handle network failures for socure#11477
Merged
AShukla-GSA merged 19 commits intomainfrom Nov 8, 2024
Merged
Conversation
amirbey
requested changes
Nov 8, 2024
Contributor
There was a problem hiding this comment.
@AShukla-GSA - 0d2fdb1, why are we now expecting redirects instead of 200s?
Contributor
Author
@amirbey after the rebase with main the main change that was affecting my tests were an addition to the socure controllers. |
…or for socure requests
…ating service and controller rspec tests
…he top request level
…nce try again functionality is implemented
…auth response, and changing/updating tests
AShukla-GSA
force-pushed
the
lg-14790-handle-network-failures-for-socure
branch
from
0d2fdb1 to
52ae44d
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-14790
🛠 Summary of changes
Implemented handle_connection_error for socure requests.
Follow Up PR after reverting 1st PR