Extract password view setup behaviors from shared email confirmation behavior#11467
Merged
Extract password view setup behaviors from shared email confirmation behavior#11467
Conversation
aduth
commented
Nov 7, 2024
Contributor
Author
There was a problem hiding this comment.
AFAICT we weren't ever using this locals assignment, since the view references @confirmation_token directly. Locals are intended to be referenced without the @.
mdiarra3
approved these changes
Nov 7, 2024
kevinsmaster5
approved these changes
Nov 7, 2024
12df960 to
ed586a4
Compare
changelog: Internal, Performance, Extract shared email confirmation behavior as needed
Probably redundant, but safer to limit impact for initial refactoring
ed586a4 to
3771936
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates shared code for email confirmation token to only be called as needed.
As mentioned in #11466, email confirmation happens across two controllers, which each individually validate the incoming confirmation token. Prior to these changes, the validation included a few things performed in both the initial email confirmation, as well as the password setup screen:
Since these are only relevant for the display of the password setup screen, the changes here move the code into the password setup controller.
📜 Testing Plan
Verify no regressions of expected behavior:
examplelongemailaddress@example.comexamplelongemailaddress@example.com