Skip to content

LG-14888: Update Spanish strings for LQA feedback#11448

Merged
aduth merged 1 commit intomainfrom
aduth-lg-14888-lqa
Nov 4, 2024
Merged

LG-14888: Update Spanish strings for LQA feedback#11448
aduth merged 1 commit intomainfrom
aduth-lg-14888-lqa

Conversation

@aduth
Copy link
Copy Markdown
Contributor

@aduth aduth commented Nov 4, 2024

🎫 Ticket

LG-14888

🛠 Summary of changes

Updates a few translations based on feedback from translators.

📜 Testing Plan

Verify updated text for reCAPTCHA disclosure in Spanish:

Prerequisite: Configure real reCAPTCHA in local development. Any credentials work, they don't need to be valid:

# config/application.yml
development:
  recaptcha_site_key: 'test'
  recaptcha_enterprise_api_key: 'test'
  recaptcha_enterprise_project_id: 'test'
  recaptcha_mock_validator: false
  sign_in_recaptcha_score_threshold: 0.3
  sign_in_recaptcha_percent_tested: 100
  1. Go to http://localhost:3000/es/
  2. See updated translations

Verify updated text for "Email not selected" in Spanish:

  1. Go to http://localhost:3000/
  2. Sign in
  3. From account page, go to "Your connected accounts"
  4. If you don't have any connected accounts, run and sign in to sample application
  5. If you have a connected account that already has a linked email address, reset through rails console: User.find_with_email('<insert email address>').identities.update_all(email_address_id: nil)
  6. Change page language to Spanish
  7. See updated translations

👀 Screenshots

Text Before After
reCAPTCHA disclosure lqa-es-recaptcha-before lqa-es-recaptcha-after
Connected accounts lqa-es-select-email-before lqa-es-select-email-after

changelog: User-Facing Improvements, Localization, Improve Spanish for reCAPTCHA disclosure and partner selected email
@aduth aduth requested a review from a team November 4, 2024 20:38
Copy link
Copy Markdown
Contributor

@kevinsmaster5 kevinsmaster5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Works locally 👍

@aduth aduth merged commit 257f49e into main Nov 4, 2024
@aduth aduth deleted the aduth-lg-14888-lqa branch November 4, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants