LG-14049 Fix barcode info alert dates and content by shanechesnutt-ft · Pull Request #11398 · 18F/identity-idp

shanechesnutt-ft · 2024-10-25T14:48:01Z

changelog: User-Facing Improvements, In-person proofing, Fix barcode page due date format for Spanish, French, and Chinese translations; Improve Spanish translation for information alert.

🎫 Ticket

Link to the relevant ticket:
LG-14049

🛠 Summary of changes

Fixed barcode page due date format for Spanish (<day> de <month> de <year>), French (<day> <month> <year>), and Chinese (<year>年<month>]月<day>日) translations; Improved the Spanish translation for the information alert.

Note: This PR fixes the time.formats.event_date translation and will update other areas of the code found in the Other Areas of the screenshots section.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

Login through the oidc sinatra application selecting a non Enhanced In-person Proofing level of service.
Use an exisiting account or create an account
Continue through the In-person flow until reaching the barcode page
Ensure English, Spanish, French, and Chinese date formats are matching Jira Ticket AC
Ensure the Spanish translation for the the information alert matches the Jira Ticket AC

👀 Screenshots

EIPP Ready to Verify Page

EIPP Ready to Verify Email

EIPP Ready to Verify Reminder Email

ID-IPP Ready to Verify Page

ID-IPP Ready to Verify Email

ID-IPP Ready to Verify Reminder Email

Other Areas

Account View - pending enrollment

Account View - date personal key was created

LG99 Screen

Verified Info Failure - Email

Verified Info Successfully - Email

Verify by mail - enter your verification code

Verify by mail - reminder email

Verify your information screen

mitchellhenke · 2024-10-25T14:52:50Z

config/locales/es.yml

should we use this for event date if the current one is wrong?

Okay, I wasn't sure if the change should app wide or not which is why I created a new translation.

I think it's worth considering. If the new translation is more correct and we're still using the old one in other places, we should probably lean towards updating the existing one unless there's a compelling reason not to.

We have time.formats.full_date, time.formats.event_date, date.formats.long, which are all kind of similar to each other and time.formats.standard_long.

There are also other dates for IPP that use event_date, ex:

identity-idp/app/presenters/account_show_presenter.rb

Lines 77 to 79 in a534a34

def formatted_ipp_due_date

I18n.l(user.pending_in_person_enrollment.due_date, format: :event_date)

end

so I think it's probably worth just updating event_date for this

I agree I will update the time.format.event_date, but let me confirm with design to see if there is a compelling reason to not to update the format app wide.

rutvigupta-design

@shanechesnutt-ft thanks for all the screenshots, this LGTM! Can you please tag me or Kelli once this is merged, so we can send screenshots back to the State Dept? Thank you!

eileen-nava

Approved! I didn't manually test this, however, I'm comfortable approving it based on the automated tests and screenshots. Thanks for doing this.

eileen-nava · 2024-10-25T20:08:06Z

config/locales/en.yml

eileen-nava · 2024-10-25T20:10:54Z

spec/presenters/idv/in_person/ready_to_verify_presenter_spec.rb

This is super readable. 👍🏻

mitchellhenke

I think we should confirm whether we want to create a new format or update the existing one. I lean towards updating the existing one.

shanechesnutt-ft · 2024-10-25T21:19:54Z

I think we should confirm whether we want to create a new format or update the existing one. I lean towards updating the existing one.

I updated the existing time.formats.event_date translations

aduth · 2024-10-28T19:06:45Z

app/presenters/idv/in_person/ready_to_verify_presenter.rb

Sorta curious why this had to change from strftime to I18n.l, or was that more of a readability improvement / consistent change?

That previous version wasn't displaying the months with the correct translated month name. The I18n.l or localize method will correctly translate the month names when formatting the date.

aduth · 2024-10-28T19:09:51Z

spec/presenters/idv/in_person/ready_to_verify_presenter_spec.rb

I see the example follows what's in the ticket, but without any demarcations, how is someone supposed to differentiate dates like “2024112” between being January 12th or November 2nd?

The Chinese Translation has been updated to be <year>年<month>月<day>日

e.g. January 12, 2024 would be 2024年1月12日

jennyverdeyen

Looks good! I tested the ready to verify page as well as the emails and all the content updates appear correct to me. Thanks for the screenshots of all the other areas!

eileen-nava

I did a second review. Good test coverage. Approved. (Caveat: I didn't manually test. I am comfortable approving this PR without manual testing, based on the automated tests.)

eileen-nava · 2024-11-07T17:19:28Z

config/locales/zh.yml

eileen-nava · 2024-11-07T17:21:09Z

spec/presenters/idv/in_person/ready_to_verify_presenter_spec.rb

Good test coverage. 👍🏻

eileen-nava · 2024-11-07T17:22:08Z

spec/presenters/idv/in_person/verification_results_email_presenter_spec.rb

rutvigupta-design · 2024-11-07T17:38:12Z

@shanechesnutt-ft the updated Chinese date format LGTM! I'll send to DOS for LQA as well :)

changelog: User-Facing Improvements, In-person proofing, Fix barcode page due date format for spanish, french, and chinese translations; Improve spanish translation for information alert. This commit updates the time.formats.event_date for Spanish, French, and Chinese, so more than just EIPP/ID-IPP flows are affected by this change. See #11398 for the areas affected.

mitchellhenke reviewed Oct 25, 2024

View reviewed changes

shanechesnutt-ft force-pushed the sc/LG-14049 branch from 8fe0f31 to 995d16d Compare October 25, 2024 15:07

shanechesnutt-ft requested review from a team, jennyverdeyen and rutvigupta-design and removed request for a team October 25, 2024 15:21

rutvigupta-design approved these changes Oct 25, 2024

View reviewed changes

eileen-nava approved these changes Oct 25, 2024

View reviewed changes

mitchellhenke requested changes Oct 25, 2024

View reviewed changes

shanechesnutt-ft force-pushed the sc/LG-14049 branch from 995d16d to 8de98cc Compare October 25, 2024 21:18

mitchellhenke approved these changes Oct 28, 2024

View reviewed changes

shanechesnutt-ft force-pushed the sc/LG-14049 branch from 8de98cc to 6209200 Compare October 28, 2024 13:48

shanechesnutt-ft requested review from a team October 28, 2024 19:03

aduth reviewed Oct 28, 2024

View reviewed changes

jennyverdeyen approved these changes Oct 29, 2024

View reviewed changes

shanechesnutt-ft force-pushed the sc/LG-14049 branch 2 times, most recently from 150f3d4 to 8c04a54 Compare November 5, 2024 19:27

shanechesnutt-ft force-pushed the sc/LG-14049 branch from 8c04a54 to a9b9856 Compare November 5, 2024 22:08

shanechesnutt-ft marked this pull request as ready for review November 5, 2024 22:10

shanechesnutt-ft force-pushed the sc/LG-14049 branch from a9b9856 to 6bde518 Compare November 5, 2024 22:22

shanechesnutt-ft force-pushed the sc/LG-14049 branch from 6bde518 to 0d70dde Compare November 7, 2024 14:54

eileen-nava approved these changes Nov 7, 2024

View reviewed changes

shanechesnutt-ft force-pushed the sc/LG-14049 branch from 0d70dde to 4dc4492 Compare November 7, 2024 21:43

shanechesnutt-ft merged commit b0a739c into main Nov 7, 2024

shanechesnutt-ft deleted the sc/LG-14049 branch November 7, 2024 22:13

aduth mentioned this pull request Nov 12, 2024

Deploy RC 430 to Prod #11494

Merged

	def formatted_ipp_due_date
	I18n.l(user.pending_in_person_enrollment.due_date, format: :event_date)
	end

Conversation

shanechesnutt-ft commented Oct 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎫 Ticket

🛠 Summary of changes

📜 Testing Plan

👀 Screenshots

Other Areas

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mitchellhenke Oct 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rutvigupta-design left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eileen-nava left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mitchellhenke left a comment

Choose a reason for hiding this comment

Uh oh!

shanechesnutt-ft commented Oct 25, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shanechesnutt-ft Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jennyverdeyen left a comment

Choose a reason for hiding this comment

Uh oh!

eileen-nava left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rutvigupta-design commented Nov 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

shanechesnutt-ft commented Oct 25, 2024 •

edited

Loading

mitchellhenke Oct 25, 2024 •

edited

Loading

rutvigupta-design left a comment •

edited

Loading

shanechesnutt-ft Nov 5, 2024 •

edited

Loading