Skip to content

Ignore unknown authncontext (#11362)#11396

Merged
Sgtpluck merged 1 commit intomainfrom
dmm/unknown-authn-context-take-two
Oct 25, 2024
Merged

Ignore unknown authncontext (#11362)#11396
Sgtpluck merged 1 commit intomainfrom
dmm/unknown-authn-context-take-two

Conversation

@Sgtpluck
Copy link
Contributor

This PR is reverting a revert (I was worried it was related to a problem with the sample SAML staging app, but looks like it is not the cause). The original PR comment is copied below

🎫 Ticket

Link to the relevant ticket:
Ignore unknown authentication contexts
Link to 1-pager

🛠 Summary of changes

This change updates our SAML integration to allow and ignore unknown authentication context class reference (ACR) values that are sent via the request, as long as there is at least one valid AuthnContext value that we can assert. (OIDC already allowed arbitrary values to be passed in.)

SAML spec line 1820

If Comparison is set to "exact" or omitted, then the resulting authentication context in the authentication
statement MUST be the exact match of at least one of the authentication contexts specified.

This change also:

  • Includes any unknown ACR values in authentication events
  • Adds/updates associated tests

Open questions:
I am currently handling the case of a partner passing in only unknown ACR values as invalid.

However, we do allow SAML partners to pass in no ACR values, in which case we use their service provider defaults, so an argument could be made that if we get only unknown ACR values, we should default to the SP's defaults.

My thinking is that if they are purposefully sending ACR values, that should override any defaults we have -- if they are only sending one, unknown ACR values that is more likely a mistake. Am open to arguments in favor/against this approach!

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

changelog: User-Facing Improvements, Integration Experience, Allowing and ignoring unknown authn_context values
@Sgtpluck Sgtpluck merged commit eca5f8d into main Oct 25, 2024
@Sgtpluck Sgtpluck deleted the dmm/unknown-authn-context-take-two branch October 25, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants