Skip to content

Log the user of a fraud rejected profile on automatic rejection #11384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmhooper merged 1 commit into from
Oct 22, 2024
Merged

Log the user of a fraud rejected profile on automatic rejection #11384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/jobs/fraud_rejection_daily_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,19 @@ class FraudRejectionDailyJob < ApplicationJob
def perform(_date)
profiles_eligible_for_fraud_rejection.find_each do |profile|
profile.reject_for_fraud(notify_user: false)
analytics.automatic_fraud_rejection(
analytics(user: profile.user).automatic_fraud_rejection(
fraud_rejection_at: profile.fraud_rejection_at,
)
end
end

private

def analytics(user: AnonymousUser.new)
def analytics(user:)
Analytics.new(user: user, request: nil, session: {}, sp: nil)
end

def profiles_eligible_for_fraud_rejection
Profile.where(fraud_review_pending_at: ..30.days.ago)
Profile.includes(:user).where(fraud_review_pending_at: ..30.days.ago)
end
end
9 changes: 4 additions & 5 deletions spec/jobs/fraud_rejection_daily_job_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,16 @@
subject(:job) { FraudRejectionDailyJob.new }
let(:job_analytics) { FakeAnalytics.new }

before do
allow(job).to receive(:analytics).and_return(job_analytics)
end

describe '#perform' do
it 'rejects profiles which have been review pending for more than 30 days' do
create(:profile, fraud_review_pending_at: 31.days.ago)
rejectedable_profile = create(:profile, fraud_review_pending_at: 31.days.ago)
create(:profile, fraud_review_pending_at: 20.days.ago)

rejected_profiles = Profile.where.not(fraud_rejection_at: nil)

allow(job).to receive(:analytics).with(user: rejectedable_profile.user).
and_return(job_analytics)

expect { job.perform(Time.zone.today) }.to change { rejected_profiles.count }.by(1)
expect(job_analytics).to have_logged_event(
'Fraud: Automatic Fraud Rejection',
Expand Down