Skip to content

Will/lg 14363#11370

Merged
WilliamBirdsall merged 1 commit intomainfrom
will/LG-14363
Oct 22, 2024
Merged

Will/lg 14363#11370
WilliamBirdsall merged 1 commit intomainfrom
will/LG-14363

Conversation

@WilliamBirdsall
Copy link
Contributor

@WilliamBirdsall WilliamBirdsall commented Oct 21, 2024

🎫 Ticket

Link to the relevant ticket:
LG-14363

🛠 Summary of changes

Remove usage of the in_person_public_address_search_enabled variable in the code base. This variable was a flag for testing but now that it is an always on feature, we can clean up the code base and remove the flag.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Step 1: Login through the Sinatra App
  • Step 2: Navigate through IPP flow until you reach PO address search screen
  • Step 3: Verify no errors with PO address search

@WilliamBirdsall WilliamBirdsall marked this pull request as draft October 21, 2024 15:07
@WilliamBirdsall WilliamBirdsall marked this pull request as ready for review October 22, 2024 14:24
Copy link
Contributor

@eileen-nava eileen-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, approved. 👍🏻

@WilliamBirdsall
Copy link
Contributor Author

Merging this today but updating the s3 variables on dev and prod on thursday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants