Skip to content

lg-14514 Remove document capture session validation event #11361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AShukla-GSA merged 3 commits into from
Oct 18, 2024
Merged

lg-14514 Remove document capture session validation event #11361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03041c4
changelog: Internal, event tracking, remove out dated doc auth event …
AShukla-GSA Oct 16, 2024
ce76aaf
Removing tests that check for outdated logs
AShukla-GSA Oct 17, 2024
c522546
Removing unneeded stub_analytics from before block of entry controlle…
AShukla-GSA Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions app/controllers/idv/hybrid_mobile/entry_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,6 @@ def validate_document_capture_session_id

result = Idv::DocumentCaptureSessionForm.new(document_capture_session_uuid).submit

event_properties = result.to_h.tap do |properties|
# See LG-8890 for context
properties[:doc_capture_user_id?] = session[:doc_capture_user_id].present?
end

analytics.track_event 'Doc Auth', event_properties

if result.success?
reset_session

Expand Down
40 changes: 0 additions & 40 deletions spec/controllers/idv/hybrid_mobile/entry_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
let(:idv_vendor) { Idp::Constants::Vendors::MOCK }

before do
stub_analytics
allow(IdentityConfig.store).to receive(:doc_auth_vendor).and_return(idv_vendor)
allow(IdentityConfig.store).to receive(:doc_auth_vendor_default).and_return(idv_vendor)
end
Expand All @@ -35,15 +34,6 @@
get :show, params: { 'document-capture-session': 'foo' }
end

it 'logs an analytics event' do
expect(@analytics).to have_logged_event(
Comment thread
AShukla-GSA marked this conversation as resolved.
'Doc Auth',
hash_including(
success: false,
errors: { session_uuid: ['invalid session'] },
),
)
end
it 'redirects to the root url' do
expect(response).to redirect_to root_url
end
Expand Down Expand Up @@ -78,16 +68,6 @@
it 'redirects to the first step' do
expect(response).to redirect_to idv_hybrid_mobile_socure_document_capture_url
end

it 'logs an analytics event' do
expect(@analytics).to have_logged_event(
'Doc Auth',
hash_including(
success: true,
doc_capture_user_id?: false,
),
)
end
end

context 'doc auth vendor is lexis nexis' do
Expand All @@ -96,16 +76,6 @@
it 'redirects to the first step' do
expect(response).to redirect_to idv_hybrid_mobile_document_capture_url
end

it 'logs an analytics event' do
expect(@analytics).to have_logged_event(
'Doc Auth',
hash_including(
success: true,
doc_capture_user_id?: false,
),
)
end
end

context 'but we already had a session' do
Expand All @@ -127,16 +97,6 @@
expect(controller.session).to include(document_capture_session_uuid: session_uuid)
end

it 'logs an analytics event' do
expect(@analytics).to have_logged_event(
'Doc Auth',
hash_including(
success: true,
doc_capture_user_id?: true,
),
)
end

context 'doc auth vendor is socure' do
let(:idv_vendor) { Idp::Constants::Vendors::SOCURE }

Expand Down