Skip to content

LG-14642: Update design and copy of GPO 'letter on the way' email#11351

Merged
lmgeorge merged 10 commits intomainfrom
lmgeorge/LG-14642
Oct 28, 2024
Merged

LG-14642: Update design and copy of GPO 'letter on the way' email#11351
lmgeorge merged 10 commits intomainfrom
lmgeorge/LG-14642

Conversation

@lmgeorge
Copy link
Contributor

@lmgeorge lmgeorge commented Oct 16, 2024

Why

  • Align the 'letter requested' design and language with our current design requirements

How

  • Rewrote the email template to utilize the new language and iconography.
  • The template handles more complexity -- if the ServiceProvider is absent or has incomplete configuration details, we account for that and either hide or modify certain instructions and the call-to-action. This business logic is stored in a new presenter (Idv::ByMail::LetterRequestedPresenter).
  • Replaced user_mailer.letter_reminder.* with new message properties under user_mailer.verify_by_mail_letter_requested.*
  • Updated the Rails mailer previewer to include a dummy ServiceProvider and User with a pending profile to reflect the new content.

Additional Notes
As we utilize Rails.application.routes.url_helpers directly in the presenter, LocaleHelper#with_user_locale also needed to handle updating the locale within the url_options hash while also maintaining support for services that do not use url_helpers directly (e.g., SendProofingNotificationJob).

By default, it appears that Rspec mocks url_options with a frozen hash, so we simply override it for the purposes of testing. A scenario where url_options is defined but equal to nil is not supported. In the event this happens, we want the interpreter to throw an error because it likely indicates a serious misconfiguration or bug in the app.

changelog: User-Facing Improvements, IdV notifications, Redesign verify-by-mail 'letter requested' email notification

🎫 Ticket

Link to the relevant ticket:
LG-14642

@lmgeorge lmgeorge requested review from aduth and jmhooper October 16, 2024 21:08
@lmgeorge
Copy link
Contributor Author

lmgeorge commented Oct 16, 2024

Author's note: currently waiting for program requirements to be met before this can be merged , but review and acceptance can still happen!

This work has been accepted, but still needs final business approval from program.

@lmgeorge lmgeorge added status - accepted Work that has passed acceptance, but may not be greenlit for release and removed status - ready for review status - blocked labels Oct 22, 2024
**Why**

- Align the 'letter requested' design and language with our current
  design requirements

**How**

- Rewrote the email template to utilize the new language and iconography.
- The template handles more complexity -- if the ServiceProvider is absent or has incomplete
  configuration details, we account for that and either hide or modify certain
  instructions and the call-to-action. This business logic is stored in
  a new presenter (`Idv::ByMail::LetterRequestedPresenter`).
- Replaced `user_mailer.letter_reminder.*` with new message properties under
  `user_mailer.verify_by_mail_letter_requested.*`
- Updated the Rails mailer previewer to include a dummy ServiceProvider
  and User with a pending profile to reflect the new content.

changelog: User-Facing Improvements, IdV notifications, Redesign verify-by-mail 'letter requested' email notification
@lmgeorge lmgeorge merged commit 085a3f1 into main Oct 28, 2024
@lmgeorge lmgeorge deleted the lmgeorge/LG-14642 branch October 28, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area - usability status - accepted Work that has passed acceptance, but may not be greenlit for release type - enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants