Skip to content

LG-14067 Implement new attempts language in attempts screen#11308

Merged
AShukla-GSA merged 3 commits intomainfrom
lg-14067-implement-new-attempts-language
Oct 3, 2024
Merged

LG-14067 Implement new attempts language in attempts screen#11308
AShukla-GSA merged 3 commits intomainfrom
lg-14067-implement-new-attempts-language

Conversation

@AShukla-GSA
Copy link
Contributor

@AShukla-GSA AShukla-GSA commented Oct 3, 2024

LG-14067 Implement new attempts language in attempts screen

🎫 Ticket

Link to the relevant ticket:
LG-14067

🛠 Summary of changes

Updated text and translations for "out of attempts" screen during doc auth.

📜 Testing Plan

  • Step 1 - Go through doc auth normally (Mobile or Desktop), failing each step until you are out of attempts.
  • Step 2 - Ensure new text matches Figma attached in ticket

👀 Screenshots

After: Screenshot 2024-10-03 at 9 45 58 AM Screenshot 2024-10-03 at 9 46 28 AM

Copy link

@sudgalag sudgalag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from content / design perspective!

Copy link
Contributor

@jmax-gsa jmax-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(I should really say that in all four languages...)

@AShukla-GSA AShukla-GSA merged commit e11fde3 into main Oct 3, 2024
@AShukla-GSA AShukla-GSA deleted the lg-14067-implement-new-attempts-language branch October 3, 2024 20:25
Comment on lines +1019 to +1020
idv.failure.attempts_html.one: You can try <strong>1 more time.</strong> Then, you must wait 6 hours before trying again.
idv.failure.attempts_html.other: You can try <strong>%{count} more times.</strong> Then, you must wait 6 hours before trying again.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is based on a configuration value that could change (doc_auth_attempt_window_in_minutes), I think we should probably have interpolate the timespan, possibly using distance_of_time_in_words (docs, extended with dotiw gem).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticketing this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants