Skip to content

Move FACIAL_MATCH_IDV_LEVELS constant to Profile #11306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vrajmohan merged 2 commits into from
Oct 2, 2024
Merged

Move FACIAL_MATCH_IDV_LEVELS constant to Profile #11306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a52f63
Move FACIAL_MATCH_IDV_LEVELS constant to Profile
vrajmohan Oct 2, 2024
1e001ed
Update app/models/user.rb
vrajmohan Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/models/profile.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# frozen_string_literal: true

class Profile < ApplicationRecord
FACIAL_MATCH_IDV_LEVELS = %w[unsupervised_with_selfie in_person].to_set.freeze

belongs_to :user
# rubocop:disable Rails/InverseOf
belongs_to :initiating_service_provider,
Expand Down Expand Up @@ -310,7 +312,7 @@ def profile_age_in_seconds
end

def facial_match?
::User::FACIAL_MATCH_IDV_LEVELS.include?(idv_level)
FACIAL_MATCH_IDV_LEVELS.include?(idv_level)
end

private
Expand Down
4 changes: 1 addition & 3 deletions app/models/user.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ class User < ApplicationRecord
MAX_RECENT_EVENTS = 5
MAX_RECENT_DEVICES = 5

FACIAL_MATCH_IDV_LEVELS = %w[unsupervised_with_selfie in_person].to_set.freeze

enum otp_delivery_preference: { sms: 0, voice: 1 }

# rubocop:disable Rails/HasManyOrHasOneDependent
Expand Down Expand Up @@ -377,7 +375,7 @@ def identity_verified?
end

def identity_verified_with_facial_match?
FACIAL_MATCH_IDV_LEVELS.include?(active_profile&.idv_level)
active_profile.present? && active_profile.facial_match?
end

# This user's most recently activated profile that has also been deactivated
Expand Down