Conversation
Sgtpluck
commented
Oct 2, 2024
| '1' => 'http://idmanagement.gov/ns/assurance/ial/1', | ||
| '2' => 'http://idmanagement.gov/ns/assurance/ial/2', | ||
| 'biometric-comparison-required' => 'http://idmanagement.gov/ns/assurance/ial/2', | ||
| 'facial-match-required' => 'http://idmanagement.gov/ns/assurance/ial/2', |
Contributor
Author
There was a problem hiding this comment.
this value doesn't matter because the ial2_params method adds the values. (it currently adds a vector of trust, but i will be updating that soon)
zachmargolis
approved these changes
Oct 2, 2024
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
I would have titled this something like "More renaming to Facial Matching" because I feel like "Update YML files" undersells it a bit.
The code LGTM!
mitchellhenke
approved these changes
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://gitlab.login.gov/lg-people/Melba/backlog-fy24/-/issues/116
🛠 Summary of changes
This change wraps up the rest of the language change from biometric_comparison to facial_match.