Skip to content

LG-14169 visual and content changes to split doc auth#11285

Merged
AShukla-GSA merged 3 commits intomainfrom
lg-14169-visual-content-changes-to-split-doc-auth-app-dev-review
Oct 2, 2024
Merged

LG-14169 visual and content changes to split doc auth#11285
AShukla-GSA merged 3 commits intomainfrom
lg-14169-visual-content-changes-to-split-doc-auth-app-dev-review

Conversation

@AShukla-GSA
Copy link
Contributor

visual and content changes for split doc auth capture pages

🎫 Ticket

Link to the relevant ticket:
LG-14169
Follow Up to PR: #11245 that was merged in prematurely and reverted.

🛠 Summary of changes

Write a brief description of what you changed.
Changed visuals and content to match Figma and AC listed in the ticket

Copy link
Contributor

@solipet solipet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally and compared with Figma - only difference I saw was the warning we give users isn't shown in Figma.

@AShukla-GSA AShukla-GSA changed the title LG 14169 visual and content changes to split doc auth LG-14169 visual and content changes to split doc auth Sep 26, 2024
@AShukla-GSA AShukla-GSA force-pushed the lg-14169-visual-content-changes-to-split-doc-auth-app-dev-review branch from 5014018 to 6dd2be2 Compare October 1, 2024 18:22
Copy link
Contributor

@jmax-gsa jmax-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@theabrad theabrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AShukla-GSA AShukla-GSA merged commit 7741e16 into main Oct 2, 2024
@AShukla-GSA AShukla-GSA deleted the lg-14169-visual-content-changes-to-split-doc-auth-app-dev-review branch October 2, 2024 21:17
border-width: 3px;
}

usa-file-input:not(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is meant to be a CSS class selector, but it's currently implemented as an element selector, so it's probably not working as intended.

Suggested change
usa-file-input:not(
.usa-file-input:not(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants