LG-14396 threat metrix create account device profiling#11278
Merged
Conversation
matthinz
reviewed
Sep 24, 2024
Contributor
matthinz
left a comment
matthinz
left a comment
There was a problem hiding this comment.
Looking good, left a few comments
mdiarra3
changed the title
kevinsmaster5
approved these changes
Sep 26, 2024
Contributor
kevinsmaster5
left a comment
kevinsmaster5
left a comment
There was a problem hiding this comment.
Looks good.
checked out locally and behaves as expected
aduth
reviewed
Oct 4, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
I would have expected to see some test coverage included here, e.g. for ThreatMetrixHelper, expected view rendering behavior for Tmx enabled, FeatureManagement#account_creation_device_profiling_collecting_enabled?.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-14396
🛠 Summary of changes
This adds device profiling for account creation, it leverages the same framework as for Proofing threat metrix profiling
📜 Testing Plan
Verify that when
account_creation_device_profilingis set to enabled or collect_only the threatmetrix javascript appears on create your account page.Example: