Add NewRelic method tracers to the AbTest bucket tooling#11275
Merged
Conversation
We are considering using a different hash algorithm for the `AbTest#bucket` method. We expect a different hashing algorithm to give us better performance which could be a meaningful bump considering how much we call the `#bucket` method every request. This commit lays some groundwork by adding method tracers to the impacted methods. This will allow us to assess the impact this change could have. [skip changelog]
zachmargolis
approved these changes
Sep 23, 2024
AShukla-GSA
pushed a commit
that referenced
this pull request
Sep 30, 2024
We are considering using a different hash algorithm for the `AbTest#bucket` method. We expect a different hashing algorithm to give us better performance which could be a meaningful bump considering how much we call the `#bucket` method every request. This commit lays some groundwork by adding method tracers to the impacted methods. This will allow us to assess the impact this change could have. [skip changelog]
Contributor
Can you link to some context for this discussion? |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are considering using a different hash algorithm for the
AbTest#bucketmethod. We expect a different hashing algorithm to give us better performance which could be a meaningful bump considering how much we call the#bucketmethod every request.This commit lays some groundwork by adding method tracers to the impacted methods. This will allow us to assess the impact this change could have.