LG-14370 Add biographical info to proofing result#11258
Merged
Conversation
Currently we log PII or redacted PII related to the resolution proofing job in the `IdV: doc auth verify proofing results` event. This primarily includes state ID information which is added to the logs in `VerifyInfoConcern#idv_result_to_form_response`. This commit adds this information to the result that is returned from `ResultAdjudicator`. This has a few advantages: 1. We have a consistent result since the infoarmation is added before bing written to Redis. This will allows the `SocureShadowModeProofingJob` to pick it up and log it. 2. It provides an overview of what PII and redacted PII is logged in one place. 3. It ensures that PII is logged consistently even if vendors or stages change in the future Finally, this commit adds the year of birth to the logs to addres LG-14371. [skip changelog]
matthinz
approved these changes
Sep 18, 2024
jmhooper
deleted the
jmhooper-add-biographical-info-to-proofing-result
branch
AShukla-GSA
pushed a commit
that referenced
this pull request
Sep 30, 2024
Currently we log PII or redacted PII related to the resolution proofing job in the `IdV: doc auth verify proofing results` event. This primarily includes state ID information which is added to the logs in `VerifyInfoConcern#idv_result_to_form_response`. This commit adds this information to the result that is returned from `ResultAdjudicator`. This has a few advantages: 1. We have a consistent result since the information is added before bing written to Redis. This will allows the `SocureShadowModeProofingJob` to pick it up and log it. 2. It provides an overview of what PII and redacted PII is logged in one place. 3. It ensures that PII is logged consistently even if vendors or stages change in the future Finally, this commit adds the year of birth to the logs to address LG-14371. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we log PII or redacted PII related to the resolution proofing job in the
IdV: doc auth verify proofing resultsevent. This primarily includes state ID information which is added to the logs inVerifyInfoConcern#idv_result_to_form_response.This commit adds this information to the result that is returned from
ResultAdjudicator. This has a few advantages:SocureShadowModeProofingJobto pick it up and log it.Finally, this commit adds the year of birth to the logs to address LG-14371.