Move Aaguid call in webauthn Setup form

[mdiarra3]

No description provided.

[aduth]

Context: #11138 (comment)

Looks like there's an issue to be resolved from the build.

[mdiarra3]

It looks like attestation response could also throw an error when we call for authenticator data. So we would need to do a begin and rescue clause as well.

[aduth]

It looks like attestation response could also throw an error when we call for authenticator data. So we would need to do a begin and rescue clause as well.

I'm not really sure I follow from the code how that could happen, since attestation_response is an attr_reader so shouldn't have any side-effects on its own.

[aduth]

Oh, I see, it's not the call to attestation_response, it's attestation_response's internal logic when we drill down into authenticator_data, if it's not a valid response.

[aduth]

1. We can use a method-level rescue to flatten this.
2. I think we can be more targeted in the error we're looking for. Based on where I suspect it's being raised, maybe we can rescue WebAuthn::AuthenticatorDataFormatError ?
3. Memoizing won't do much here if the value is nil, since ||= will still evaluate for a nil value

Suggested change

	def aaguid
	begin
	@aaguid ||= attestation_response&.authenticator_data&.aaguid
	rescue StandardError
	nil
	end
	end
	def aaguid
	attestation_response&.authenticator_data&.aaguid
	rescue WebAuthn::AuthenticatorDataFormatError
	nil
	end

[aduth]

Ok looks like we are getting StandardError after all? 🤷

From adding a binding.pry and running failing spec rspec ./spec/forms/webauthn_setup_form_spec.rb:226.

From: /Users/andrewmduthie/Documents/Code/identity-idp/app/forms/webauthn_setup_form.rb:167 WebauthnSetupForm#aaguid:

    163: def aaguid
    164:   attestation_response&.authenticator_data&.aaguid
    165: rescue => e
    166:   binding.pry
 => 167:   nil
    168: end

[1] pry(#<WebauthnSetupForm>)> e
=> #<StandardError: StandardError>

Curious where this is being raised...

Suggested change

	rescue WebAuthn::AuthenticatorDataFormatError
	nil
	rescue StandardError
	nil

[aduth]

Oh.... it's because it's what we stub 😕

identity-idp/spec/forms/webauthn_setup_form_spec.rb

Lines 222 to 224 in f982fda

	before do
	allow(WebAuthn::AttestationStatement).to receive(:from).and_raise(StandardError)
	end

I'm not sure that stub accurately reflects reality.

[mdiarra3]

Yea I think we can change it to reflect webauthn data error

[mdiarra3]

But it doesnt explain why the other tests are failing as well.

[aduth]

LGTM 👍