-
Notifications
You must be signed in to change notification settings - Fork 167
LG-14100 Include identity-verified status in account reset delete event #11236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
b6d2df6
2e84b35
ee443a7
e55f97d
fafa0a4
359218f
5c83224
e07200c
43d8c93
ab3535a
8ca9ad4
e85f30f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -66,13 +66,20 @@ def notify_user_via_email_of_deletion | |||||
| end | ||||||
| # rubocop:enable IdentityIdp/MailLaterLinter | ||||||
|
|
||||||
| def profile_components | ||||||
| return nil if !user.identity_verified? | ||||||
| ProofingComponent.create_or_find_by(user: user) | ||||||
| end | ||||||
|
|
||||||
| def extra_analytics_attributes | ||||||
| { | ||||||
| user_id: user.uuid, | ||||||
| email: user.email_addresses.take&.email, | ||||||
| account_age_in_days: account_age, | ||||||
| account_confirmed_at: user.confirmed_at, | ||||||
| mfa_method_counts: mfa_method_counts, | ||||||
| proofing_components: profile_components, | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I hate to switch it up at this point, but I'm thinking it may be better off to just use (or at least start with using) the Plus, strings are a bit easier to work with than a hash 😅
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That worked great. Thanks also to @matthinz for the suggestion. |
||||||
| identity_verified: user.identity_verified?, | ||||||
| pii_like_keypaths: [[:mfa_method_counts, :phone]], | ||||||
| } | ||||||
| end | ||||||
|
|
||||||
Uh oh!
There was an error while loading. Please reload this page.