Skip to content

Remove ab_test_args stub analytics properties#11226

Merged
aduth merged 9 commits intomainfrom
aduth-rm-ab-test-args-stub
Sep 11, 2024
Merged

Remove ab_test_args stub analytics properties#11226
aduth merged 9 commits intomainfrom
aduth-rm-ab-test-args-stub

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Sep 10, 2024

🛠 Summary of changes

Updates controller specs to remove ab_test_args method stubbing.

Why?

  • We should want to know exactly what's logged, including both the value and the keyword argument being part of affected analytics event method signatures
  • These aren't really A/B tests, they're just properties controlled by a feature flag
  • This will simplify the effort to remove the in-person proofing opt-in feature flag, which has already been live in production for many months now
  • The properties are already documented for many analytics events where we're not stubbing the result, so this brings consistency
  • Allows for removing allowed_extra_analytics exceptions, particularly in feature specs, where the logged output would match more what's in the real-world, and wouldn't benefit from the stubbing implemented in controller specs

Draft until verified if CI builds reveal any unnecessary allowed_extra_analytics to be removed.

📜 Testing Plan

Verify build passes.

changelog: Internal, Analytics, Document analytics properties
@aduth aduth requested review from a team, jennyverdeyen and matthinz September 10, 2024 21:05
@aduth aduth marked this pull request as ready for review September 11, 2024 17:34
@aduth aduth merged commit cf6b59c into main Sep 11, 2024
@aduth aduth deleted the aduth-rm-ab-test-args-stub branch September 11, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants