-
Notifications
You must be signed in to change notification settings - Fork 166
LG-14308 Add an account verified but not connected template #11203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| !"#$%&'()+,-./0123456789:;>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ_abcdefghijklmnopqrstuvwxyz~ «»¿ÀÁÈÉÊÎÓÚàáâãçèéêëíîïñóôùúû ‑—‘’“”…‹中体文简 | ||
| !"#$%&'()+,-./0123456789:;>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[]_abcdefghijklmnopqrstuvwxyz~ «»¿ÀÁÈÉÊÎÓÚàáâãçèéêëíîïñóôùúû ‑—‘’“”…‹中体文简 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| <p class="lead"> | ||
| <%= t( | ||
| 'user_mailer.account_verified_but_not_connected.intro', | ||
| app_name: APP_NAME, | ||
| date: @date, | ||
| ) %> | ||
| </p> | ||
|
|
||
| <p class="lead"> | ||
| <%= t( | ||
| 'user_mailer.account_verified_but_not_connected.instructions_html', | ||
| sp_name: @sp_name, | ||
| ) %> | ||
| </p> | ||
|
|
||
| <p> | ||
| <%= link_to @sp_url, @sp_url %> | ||
| </p> | ||
|
|
||
| <table class="spacer"> | ||
| <tbody> | ||
| <tr> | ||
| <td class="s10" height="10px"> | ||
| | ||
| </td> | ||
| </tr> | ||
| </tbody> | ||
| </table> | ||
|
|
||
| <table class="hr"> | ||
| <tr> | ||
| <th> | ||
| | ||
| </th> | ||
| </tr> | ||
| </table> | ||
|
|
||
| <p> | ||
| <%= t( | ||
| 'user_mailer.account_verified_but_not_connected.help_html', | ||
| change_password_link_html: link_to( | ||
| t('user_mailer.account_verified_but_not_connected.change_password_link'), | ||
| new_user_password_url, | ||
| ), | ||
| contact_link_html: link_to(t('user_mailer.account_verified_but_not_connected.contact_link'), MarketingSite.contact_url), | ||
| ) %> | ||
| </p> |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -1801,10 +1801,17 @@ user_mailer.account_reset_request.cancel: Don’t want to delete your account? S | |||||
| user_mailer.account_reset_request.header: Your account will be deleted in %{interval} | ||||||
| user_mailer.account_reset_request.intro_html: 'As a security measure, %{app_name} requires a two-step process to delete your account:<br><br> Step One: There is a waiting period of %{waiting_period} if you have lost access to your authentication methods and need to delete your account. If you locate your authentication methods, you can sign in to your %{app_name} account to cancel this request.<br><br> Step Two: After the waiting period of %{waiting_period}, you will receive an email that will ask you to confirm the deletion of your %{app_name} account. Your account will not be deleted until you confirm.' | ||||||
| user_mailer.account_reset_request.subject: How to delete your %{app_name} account | ||||||
| user_mailer.account_verified_but_not_connected.change_password_link: change your password | ||||||
| user_mailer.account_verified_but_not_connected.contact_link: contact us | ||||||
| user_mailer.account_verified_but_not_connected.help_html: If you did not perform this action, please %{contact_link_html} and sign in to %{change_password_link_html}. | ||||||
| user_mailer.account_verified_but_not_connected.instructions_html: Sign back in at the <strong>%{sp_name}</strong> website to connect your verified information and access services. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. my vote is to move the strong tag into the ERB
Suggested change
|
||||||
| user_mailer.account_verified_but_not_connected.intro: You verified your identity with %{app_name} on %{date} | ||||||
| user_mailer.account_verified_but_not_connected.subject: '[Action required] Connect your information to %{sp_name}.' | ||||||
| user_mailer.account_verified.change_password_link: change your password | ||||||
| user_mailer.account_verified.contact_link: contact us | ||||||
| user_mailer.account_verified.intro_html: You successfully verified your identity with %{sp_name} on %{date} using %{app_name}. If you did not perform this action, please %{contact_link_html} and sign in to %{change_password_link_html}. | ||||||
| user_mailer.account_verified.subject: You verified your identity with %{sp_name}. | ||||||
| user_mailer.account_verified.help_html: If you did not perform this action, please %{contact_link_html} and sign in to %{change_password_link_html}. | ||||||
| user_mailer.account_verified.intro_html: On %{date}, you used %{app_name} to:<ul><li>Verify your identity</li><li>Connect your verified information to %{sp_name}</li></ul> | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. in the spirit of moving HTML into ERBs, I think it would be worth considering moving each sentence/bullet into its own key, and then leave the HTML markup in the template |
||||||
| user_mailer.account_verified.subject: You verified your identity for %{sp_name}. | ||||||
| user_mailer.add_email_associated_with_another_account.help_html: If you did not request a new email or suspect an error, please visit the %{app_name_html} %{help_link_html} or %{contact_link_html}. | ||||||
| user_mailer.add_email_associated_with_another_account.intro_html: This email address is already associated with a %{app_name_html} account, so we can’t add it to another account. You must first delete or remove it from the account it is associated with. To do this, follow the link below and sign in with this email address. If you are not trying to add this email address to an account, you can ignore this message. | ||||||
| user_mailer.add_email_associated_with_another_account.link_text: Go to %{app_name} | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely not germane to your PR directly, but now that we've had to regenerate fonts twice within the past month or so, I'm left wondering how much we're really saving users. Semi-regular users would have had to re-download them on each update. It's probably still a net win, but with a narrowing margin.
(My point is that I think
glyphindoror whatnot isn't hugely valuable and could be phased out, not that you should try to work around the fact that the linter made you regenerate fonts here.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous update was due to a bug. Similarly, as commented earlier, I don't think we'd really need to update these fonts here.
I think there's also an interesting discussion to be had whether to question why we're introducing new punctuation that we don't use anywhere else, and whether that's something we should want to avoid.
It's hard to argue in favor of end-user performance vs. developer ergonomics when we personally encounter the latter more often, but I still feel quite favorable to this optimization, and think we can continue to smooth out some of the rough edges.