Conversation
jmax-gsa
force-pushed
the
jmax/LG-13092-delete-duplicate-tests-in-document_capture_spec.rb
branch
from
6f77503 to
e8f3079
Compare
solipet
reviewed
Sep 3, 2024
`expect_review_issues_body_message` and `expect_rate_limit_warning`
`expect_resubmit_page_inline_error_messages` `expect_resubmit_page_inline_selfie_error_message`
And little bit of other utility routines.
changelog: Internal,Spec improvements,consolidated some feature specs for speed and reduced duplication.
Unintentional checkin.
Co-authored-by: Doug Price <douglas.price@gsa.gov>
jmax-gsa
force-pushed
the
jmax/LG-13092-delete-duplicate-tests-in-document_capture_spec.rb
branch
from
19540f4 to
fa79f7a
Compare
jmax-gsa
deleted the
jmax/LG-13092-delete-duplicate-tests-in-document_capture_spec.rb
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-13092
🛠 Summary of changes
Consolidated a bunch of test cases in
features/idv/doc_auth/document_capture_spec.rbfor speed and eliminated some test duplication.All of the doc capture error handling except rate limiting is now tested in a single inline test (that bumps the rate limits so that we don't trip over them) that retries with different error conditions to check the messages shown for each. This is much faster than restarting IdV from scratch for each error.
📜 Testing Plan