Skip to content

revert back to sending mock client metadata only when using the mock doc auth vendor#11150

Merged
amirbey merged 4 commits intomainfrom
amirbey/LG-14314-file-picker-file-type-bug
Aug 27, 2024
Merged

revert back to sending mock client metadata only when using the mock doc auth vendor#11150
amirbey merged 4 commits intomainfrom
amirbey/LG-14314-file-picker-file-type-bug

Conversation

@amirbey
Copy link
Contributor

@amirbey amirbey commented Aug 27, 2024

🎫 Ticket

Link to the relevant ticket:
LG-14314

🛠 Summary of changes

  • the mock-client meta data is defined only when the mock-client attribute is true

📜 Testing Plan

See video recording below or follow steps

  • in application.yml, set: doc_auth_vendor: 'mock'
  • attempt to upload a file for doc auth
  • confirm file picker allows all file types
  • in application.yml, set: doc_auth_vendor: 'not-mock'
  • attempt to upload a file for doc auth
  • confirm file picker allows jpg and png files only

👀 Video Recording

https://gsa-tts.slack.com/archives/C0751MB0CAV/p1724762294302399?thread_ts=1724762259.730499&cid=C0751MB0CAV

changelog: Bug Fixes, Document Authentication, Fix mock client metadata
Copy link
Contributor

@solipet solipet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested per test plan. All file types available when mock, only jpg/png when not-mock.

@amirbey amirbey merged commit f8aeb0f into main Aug 27, 2024
@amirbey amirbey deleted the amirbey/LG-14314-file-picker-file-type-bug branch August 27, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants