Skip to content

changelog: internal, accuant capture, refactor variable name #11133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AShukla-GSA merged 7 commits into from
Aug 22, 2024
Merged

changelog: internal, accuant capture, refactor variable name #11133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
044d694
changelog: internal, accuant capture, refactor variable name
AShukla-GSA Aug 22, 2024
04e0f18
Updated spec to use updated variable name
AShukla-GSA Aug 22, 2024
df7784d
Updated events with updated clickSource variable
AShukla-GSA Aug 22, 2024
88ca3e8
Updated test to follow updated logic detailed in AC
AShukla-GSA Aug 22, 2024
aa1005d
Updated params comments to fix lint
AShukla-GSA Aug 22, 2024
6677dea
Added constinent variable names
AShukla-GSA Aug 22, 2024
51aba56
Resolving lint issue
AShukla-GSA Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/javascript/packages/document-capture/components/acuant-capture.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,17 +432,17 @@ function AcuantCapture(
}

/**
* Given a click source, returns a higher-order function that, when called, will log an event
* Given a clickSource, returns a higher-order function that, when called, will log an event
* before calling the original function.
*/
function withLoggedClick(source: string, metadata: { isDrop: boolean } = { isDrop: false }) {
function withLoggedClick(clickSource: string, metadata: { isDrop: boolean } = { isDrop: false }) {
return <T extends (...args: any[]) => any>(fn: T) =>
(...args: Parameters<T>) => {
if (!isSuppressingClickLogging.current) {
trackEvent(
name === 'selfie' ? 'idv_selfie_image_clicked' : `IdV: ${name} image clicked`,
{
source,
click_source: clickSource,
...metadata,
liveness_checking_required: isSelfieCaptureEnabled,
captureAttempts,
Expand Down Expand Up @@ -810,7 +810,7 @@ function AcuantCapture(
<span className="padding-left-1 padding-right-1">{children}</span>
),
'lg-upload': ({ children }) => (
<Button isUnstyled onClick={withLoggedClick('upload')(forceUpload)}>
<Button isUnstyled onClick={withLoggedClick('button')(forceUpload)}>
{children}
</Button>
),
Expand Down
18 changes: 9 additions & 9 deletions app/services/analytics_events.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -876,7 +876,7 @@ def idv_back_image_added(
# @param [String] acuant_version
# @param ["hybrid","standard"] flow_path Document capture user flow
# @param [Boolean] isDrop
# @param [Boolean] source
# @param [Boolean] click_source
# @param [Boolean] use_alternate_sdk
# @param [Number] captureAttempts count of image capturing attempts
# @param [String] liveness_checking_required Whether or not the selfie is required
Expand All @@ -885,7 +885,7 @@ def idv_back_image_clicked(
acuant_version:,
flow_path:,
isDrop:,
source:,
click_source:,
use_alternate_sdk:,
captureAttempts:,
liveness_checking_required:,
Expand All @@ -897,7 +897,7 @@ def idv_back_image_clicked(
acuant_version: acuant_version,
flow_path: flow_path,
isDrop: isDrop,
source: source,
click_source: click_source,
use_alternate_sdk: use_alternate_sdk,
liveness_checking_required: liveness_checking_required,
captureAttempts: captureAttempts,
Expand Down Expand Up @@ -2121,7 +2121,7 @@ def idv_front_image_added(
# @param [String] acuant_version
# @param ["hybrid","standard"] flow_path Document capture user flow
# @param [Boolean] isDrop
# @param [String] source
# @param [String] click_source
# @param [String] use_alternate_sdk
# @param [Number] captureAttempts count of image capturing attempts
# @param [Boolean] liveness_checking_required
Expand All @@ -2130,7 +2130,7 @@ def idv_front_image_clicked(
acuant_version:,
flow_path:,
isDrop:,
source:,
click_source:,
use_alternate_sdk:,
captureAttempts:,
liveness_checking_required: nil,
Expand All @@ -2142,7 +2142,7 @@ def idv_front_image_clicked(
acuant_version: acuant_version,
flow_path: flow_path,
isDrop: isDrop,
source: source,
click_source: click_source,
use_alternate_sdk: use_alternate_sdk,
liveness_checking_required: liveness_checking_required,
captureAttempts: captureAttempts,
Expand Down Expand Up @@ -4137,7 +4137,7 @@ def idv_selfie_image_added(
# @param [String] acuant_version
# @param ["hybrid","standard"] flow_path Document capture user flow
# @param [Boolean] isDrop
# @param [String] source
# @param [String] click_source
# @param [String] use_alternate_sdk
# @param [Number] captureAttempts
# @param [Boolean] liveness_checking_required
Expand All @@ -4149,7 +4149,7 @@ def idv_selfie_image_clicked(
acuant_version:,
flow_path:,
isDrop:,
source:,
click_source:,
use_alternate_sdk:,
captureAttempts:,
liveness_checking_required: nil,
Expand All @@ -4164,7 +4164,7 @@ def idv_selfie_image_clicked(
acuant_version: acuant_version,
flow_path: flow_path,
isDrop: isDrop,
source: source,
click_source: click_source,
use_alternate_sdk: use_alternate_sdk,
captureAttempts: captureAttempts,
liveness_checking_required: liveness_checking_required,
Expand Down
8 changes: 4 additions & 4 deletions spec/javascript/packages/document-capture/components/acuant-capture-spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1358,19 +1358,19 @@ describe('document-capture/components/acuant-capture', () => {

expect(trackEvent.callCount).to.be.at.least(3);
expect(trackEvent).to.have.been.calledWith('IdV: test image clicked', {
source: 'placeholder',
click_source: 'placeholder',
isDrop: false,
liveness_checking_required: false,
captureAttempts: 1,
});
expect(trackEvent).to.have.been.calledWith('IdV: test image clicked', {
source: 'button',
click_source: 'button',
isDrop: false,
liveness_checking_required: false,
captureAttempts: 1,
});
expect(trackEvent).to.have.been.calledWith('IdV: test image clicked', {
source: 'upload',
click_source: 'button',
isDrop: false,
liveness_checking_required: false,
captureAttempts: 1,
Expand All @@ -1391,7 +1391,7 @@ describe('document-capture/components/acuant-capture', () => {
fireEvent.drop(input);

expect(trackEvent).to.have.been.calledWith('IdV: test image clicked', {
source: 'placeholder',
click_source: 'placeholder',
isDrop: true,
liveness_checking_required: false,
captureAttempts: 1,
Expand Down