Add handling for missing data in CombinedInvoiceSupplementReportV2#11121
Merged
zachmargolis merged 3 commits intomainfrom Aug 21, 2024
Merged
Add handling for missing data in CombinedInvoiceSupplementReportV2#11121zachmargolis merged 3 commits intomainfrom
zachmargolis merged 3 commits intomainfrom
Conversation
- also log warning so we can investigate changelog: Bug Fixes, Reporting, Add handling for error seen first day of the month
2 tasks
MrNagoo
reviewed
Aug 21, 2024
Comment on lines
+584
to
+608
| let(:by_iaa_results) do | ||
| [ | ||
| { | ||
| key: 'IAA123', | ||
| year_month: '202408', | ||
| iaa_start_date: '2024-08-01', | ||
| iaa_end_date: '2025-07-31', | ||
| }, | ||
| ] | ||
| end | ||
|
|
||
| let(:by_issuer_results) do | ||
| [ | ||
| { | ||
| iaa: 'IAA123', | ||
| issuer: service_provider.issuer, | ||
| year_month: '202408', | ||
| }, | ||
| { | ||
| iaa: 'IAA123', | ||
| issuer: service_provider.issuer, | ||
| year_month: '202409', | ||
| }, | ||
| ] | ||
| end |
Contributor
There was a problem hiding this comment.
Is it really just a mismatch on year_month between iaas and issuers? I thought the error was happening because an issuer year_month was outside of the range of the iaa.
Contributor
Author
There was a problem hiding this comment.
I feel like the result is the same no?
Contributor
There was a problem hiding this comment.
It should be, it just makes more sense to me now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #11095
Differences: