Skip to content

LG-14220 (1): Standardize completions screen logo #11120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 4 commits into from
Aug 21, 2024
Merged

LG-14220 (1): Standardize completions screen logo #11120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25e82f3
Standardize completions screen logo
aduth Aug 20, 2024
7566793
Revert image for IPP verified
aduth Aug 20, 2024
ef7f886
Remove unused user-signup.png
aduth Aug 20, 2024
95d9097
Add explicit height for completions image
aduth Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/assets/images/user-signup-ial2.svg
View file
Open in desktop

This file was deleted.

0 app/assets/images/user-signup-ial1.svg → app/assets/images/user-signup.svg
View file
Open in desktop
File renamed without changes
12 changes: 0 additions & 12 deletions app/presenters/completions_presenter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,18 +102,6 @@ def intro
end
end

def image_name
if ial2_requested?
'user-signup-ial2.svg'
else
'user-signup-ial1.svg'
end
end

def image_alt
I18n.t('sign_up.completed.smiling_image_alt')
end

def pii
displayable_attribute_keys.index_with do |attribute_name|
displayable_pii[attribute_name]
Expand Down
2 changes: 1 addition & 1 deletion app/views/mfa_confirmation/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<% self.title = @content.heading %>

<%= image_tag asset_url('user-signup-ial1.svg'), width: 107, height: 119, alt: '', class: 'margin-bottom-4', aria: { hidden: true } %>
<%= image_tag asset_url('user-signup.svg'), width: 107, height: 119, alt: '', class: 'margin-bottom-4', aria: { hidden: true } %>

<%= render PageHeadingComponent.new.with_content(@content.heading) %>

Expand Down
9 changes: 8 additions & 1 deletion app/views/sign_up/completions/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
<% self.title = @presenter.heading %>

<div class="text-center">
<%= image_tag asset_url(@presenter.image_name), width: 140, alt: @presenter.image_alt, class: 'margin-bottom-2' %>
<%= image_tag(
asset_url('user-signup.svg'),
width: 140,
height: 156,
alt: t('sign_up.completed.smiling_image_alt'),
class: 'margin-bottom-2',
) %>
</div>

<%= render PageHeadingComponent.new(class: 'text-center') do %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/users/backup_code_setup/reminder.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<% self.title = t('forms.backup_code.title') %>

<%= image_tag asset_url('user-signup-ial1.svg'), width: 107, height: 119, alt: '', class: 'margin-bottom-4', aria: { hidden: true } %>
<%= image_tag asset_url('user-signup.svg'), width: 107, height: 119, alt: '', class: 'margin-bottom-4', aria: { hidden: true } %>

<%= render PageHeadingComponent.new.with_content(t('forms.backup_code_reminder.heading')) %>

Expand Down
24 changes: 0 additions & 24 deletions spec/presenters/completions_presenter_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,30 +146,6 @@
end
end

describe '#image_name' do
context 'ial2 sign in' do
let(:ial2_requested) { true }

it 'renders the ial2 image' do
expect(presenter.image_name).to eq('user-signup-ial2.svg')
end
end

context 'ial1 sign in' do
let(:ial2_requested) { false }

it 'renders the ial1 image' do
expect(presenter.image_name).to eq('user-signup-ial1.svg')
end
end
end

describe '#image_alt' do
it 'returns image alt test' do
expect(presenter.image_alt).to eq(I18n.t('sign_up.completed.smiling_image_alt'))
end
end

describe '#intro' do
describe 'ial1' do
context 'consent has expired since the last sign in' do
Expand Down