Merged
Conversation
zachmargolis
approved these changes
Aug 20, 2024
lib/reporting/protocols_report.rb
Outdated
Comment on lines
298
to
306
Contributor
There was a problem hiding this comment.
no need for begin...end syntax
Suggested change
| @aal3_issuers_data ||= begin | |
| cloudwatch_client.fetch( | |
| query: aal3_issuers_query, | |
| from: time_range.begin, | |
| to: time_range.end, | |
| ). | |
| map { |slice| slice['issuer'] }. | |
| uniq | |
| end | |
| @aal3_issuers_data ||= cloudwatch_client.fetch( | |
| query: aal3_issuers_query, | |
| from: time_range.begin, | |
| to: time_range.end, | |
| ). | |
| map { |slice| slice['issuer'] }. | |
| uniq |
lib/reporting/protocols_report.rb
Outdated
Contributor
There was a problem hiding this comment.
is this report usable with all these issues in the same cell like that? they're very long values
IMO if I were making a report like this, I'd have separate tables per attribute, and the table would be like
| Friendly Name | Issuer |
|---|---|
| Foobar.gov | foo:bar:baz |
| Agency.gov | foo:bar:agency |
etc
Contributor
Author
There was a problem hiding this comment.
I had suggested something similar when the original story was discussed, but it was turned down.
vrajmohan
force-pushed
the
add-aal3-to-protocols-report
branch
2 times, most recently
from
e528042 to
2e1faf5
Compare
We would like to know who is using the deprecated AAL3 ACR parameter. See https://gitlab.login.gov/lg-people/lg-people-appdev/Melba/backlog-fy24/-/issues/10 changelog: Internal, Reporting, Add AAL3 usage to protocols report
vrajmohan
force-pushed
the
add-aal3-to-protocols-report
branch
from
2e1faf5 to
adecfb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would like to know who is using the deprecated AAL3 ACR parameter.
See
https://gitlab.login.gov/lg-people/lg-people-appdev/Melba/backlog-fy24/-/issues/10
changelog: Internal, Reporting, Add AAL3 usage to protocols report