Avoid Yarn install and trace in Docker assets precompilation#11110
Merged
Avoid Yarn install and trace in Docker assets precompilation#11110
Conversation
changelog: lnternal, Continuous Integration, Improve performance of install step in continuous integration images
mitchellhenke
approved these changes
Aug 19, 2024
package.json needed for running Yarn commands. Lockfile may not strictly be necessary, but good to be safe to avoid installing unexpected versions if install is run unknowingly
Yarn installs workspace packages using symlinks, which is incompatible with Docker Related: lerna/lerna#2381
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates Dockerfiles to avoid unnecessary effort during assets precompilation:
assets:precompilewill callyarn installby default unless disabled bySKIP_YARN_INSTALL.See other references:
identity-idp/.gitlab-ci.yml
Line 79 in 0923f95
identity-idp/deploy/build-post-config
Line 21 in 0923f95
📜 Testing Plan
Verify build passes.
Check logs for "build-idp-image" and "build-review-image" in CI and observe no installation logging during assets precompilation.