Skip to content

LG-13111: Remove feature flag for email aggregation functionality#11107

Merged
aduth merged 3 commits intomainfrom
aduth-lg-13111-rm-email-aggregate-flag
Aug 20, 2024
Merged

LG-13111: Remove feature flag for email aggregation functionality#11107
aduth merged 3 commits intomainfrom
aduth-lg-13111-rm-email-aggregate-flag

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Aug 19, 2024

🎫 Ticket

LG-13111

🛠 Summary of changes

Updates code paths to assume feature_new_device_alert_aggregation_enabled as the baseline default behavior.

Recommend reviewing with whitespace changes hidden: https://github.com/18F/identity-idp/pull/11107/files?w=1

📜 Testing Plan

Verify no regressions in the behavior of new device email being sent:

  1. Sign in from an existing device and observe no email sent
  2. Sign in from a new device (e.g. private browsing window) and observe that email is sent after first of either (a) you complete MFA, or (b) 5-10 minutes elapses (depending on when scheduled job runs)

changelog: Internal, Code Quality, Remove feature flag for baseline email functionality
@aduth aduth requested a review from a team August 19, 2024 12:59
@aduth aduth merged commit 5bb3cc9 into main Aug 20, 2024
@aduth aduth deleted the aduth-lg-13111-rm-email-aggregate-flag branch August 20, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants