-
Notifications
You must be signed in to change notification settings - Fork 166
LG-14095: set up A/B testing for Socure #11104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -196,9 +196,14 @@ def self.client(vendor:, warn_notifier: nil) | |
| # rubocop:enable Layout/LineLength | ||
|
|
||
| def self.doc_auth_vendor_for_bucket(bucket) | ||
| bucket == :alternate_vendor ? | ||
| IdentityConfig.store.doc_auth_vendor_randomize_alternate_vendor : | ||
| IdentityConfig.store.doc_auth_vendor | ||
| case bucket | ||
| when :socure | ||
| Idp::Constants::Vendors::SOCURE | ||
| when :lexis_nexis | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is here since they are a vendor, even though they are currently set to the default.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this would never get a hit in the current implementation right? we would have to add a :lexis_nexis bucket in DOC_AUTH_VENDOR, right?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. correct
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i'm wondering if there is a comment that could be added to make this clear ... so that someone could know that extra code is needed to make this bucket possible to be hit |
||
| Idp::Constants::Vendors::LEXIS_NEXIS | ||
| else # e.g., nil | ||
| IdentityConfig.store.doc_auth_vendor_default | ||
| end | ||
| end | ||
|
|
||
| def self.doc_auth_vendor( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This turned out to be unused.