Skip to content

Improve Image Build Caching #11063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 5 commits into from
Aug 13, 2024
Merged

Improve Image Build Caching #11063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0a1ec4f
Improve Image Build Caching
Aug 9, 2024
0f3ffe2
remove node modules
Aug 9, 2024
f3afb3f
remove and ignore yarn cache
Aug 9, 2024
a0450e0
remove software-properties-common from main image
Aug 9, 2024
509b817
Merge branch 'main' into mitchellhenke/disable-single-snapshot-build
Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ build-idp-image:
--cache-repo="${ECR_REGISTRY}/identity-idp/idp/cache"
--cache-ttl=168h
--cache=true
--single-snapshot
--snapshot-mode=redo
--compressed-caching=false
--build-arg "http_proxy=${http_proxy}"
--build-arg "https_proxy=${https_proxy}"
Expand Down
5 changes: 2 additions & 3 deletions dockerfiles/idp_prod.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ COPY public/ban-robots.txt $RAILS_ROOT/public/robots.txt
COPY ./config/application.yml.default.prod $RAILS_ROOT/config/application.yml

# Precompile assets
RUN bundle exec rake assets:precompile --trace
RUN bundle exec rake assets:precompile --trace && rm -r node_modules/ && rm -r .yarn-cache/

# get service_providers.yml and related files
ARG SERVICE_PROVIDERS_KEY
Expand Down Expand Up @@ -136,7 +136,7 @@ RUN openssl req -x509 -sha256 -nodes -newkey rsa:2048 -days 1825 \
#########################################################################
# This is the main image.
#########################################################################
FROM ruby:3.3.4-slim
FROM ruby:3.3.4-slim as main

# Set environment variables
ENV RAILS_ROOT /app
Expand Down Expand Up @@ -179,7 +179,6 @@ RUN apt-get update -qq && \
libxml2-dev \
libxslt1-dev \
libcurl4-openssl-dev \
software-properties-common \
libffi-dev \
libpq-dev \
unzip && \
Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/idp_prod.Dockerfile.dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
/app/node_modules

/app/.yarn-cache