Skip to content

Fix spacing on PIV/CAC login screen#11032

Merged
aduth merged 1 commit intomainfrom
aduth-piv-cac-login-button
Aug 6, 2024
Merged

Fix spacing on PIV/CAC login screen#11032
aduth merged 1 commit intomainfrom
aduth-piv-cac-login-button

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Aug 6, 2024

🛠 Summary of changes

Updates margins on the PIV/CAC login screen to use standard page layout margins. Buttons are intended to have 2.5rem margin (5 spacing units) between itself and the preceding page content.

This has been an issue that's bugged me for several years now, so finally taking care of it now that content has been updated recently 😅

📜 Testing Plan

  1. Go to http://localhost:3000
  2. Click "Sign in with your government employee ID"
  3. See corrected layout

👀 Screenshots

Before After
image image

changelog: Bug Fixes, Page Layout, Fix spacing on PIV/CAC login screen
@aduth aduth requested a review from a team August 6, 2024 12:19
Copy link
Contributor

@kevinsmaster5 kevinsmaster5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aduth aduth merged commit 66b1b4e into main Aug 6, 2024
@aduth aduth deleted the aduth-piv-cac-login-button branch August 6, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants