Remove OIDC form-action CSP assertions from account creation specs#11025
Merged
Remove OIDC form-action CSP assertions from account creation specs#11025
Conversation
changelog: Internal, Automated Testing, Remove OIDC form-action CSP assertions from account creation specs
mitchellhenke
approved these changes
Aug 2, 2024
zachmargolis
approved these changes
Aug 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates account creation shared example test cases to remove assertions about CSP expectations.
Since #10997, these assertions have started failing on unrelated pull requests. The assertions are redundant, since they're already tested in
csp_spec.rb.. Limiting the amount of work performed in shared examples should also have a multiplicative benefit on runtime of these specs, since there are now 3x2 (6) fewer test cases being run.📜 Testing Plan
Verify that build passes..