Limit analytics CSP revisions to necessary entries#11021
Merged
Conversation
mitchellhenke
approved these changes
Aug 2, 2024
zachmargolis
approved these changes
Aug 2, 2024
changelog: Internal, Analytics, Limit analytics CSP revisions to necessary entries See: https://github.com/digital-analytics-program/gov-wide-code#content-security-policy
aduth
force-pushed
the
aduth-dap-csp-ga4
branch
from
ae5819a to
5e2c65a
Compare
This reverts commit 5e2c65a.
Contributor
Author
|
I'm having difficulty with the review apps, so I'll just plan to test this in staging and revert if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates content security policy to limit directives to only those strictly necessary for Digital Analytics Program.
See documentation: https://github.com/digital-analytics-program/gov-wide-code#content-security-policy
Since these conflicted with the recommendations from Google for Google Analytics, I had reached out to the DAP support team to clarify that their documented recommendations are sufficient. I'll also plan to monitor this after the changes go live to ensure there are no issues.
📜 Testing Plan
Verify that there are no errors in browser developer tools console when loading the preview site for this branch:
TBD
(It's enabled temporarily in preview environments, but this will be removed prior to merging)