LG-13896: State ID expiration validation

[amirbey]

🎫 Ticket

LG-13896

🛠 Summary of changes

Check to see if the the state ID expiration date has not past when validating user data extracted from the ID.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

• Submit an ID or yaml file with an expiration date that has past and verify the user proceeds to the SSN page
• Submit an ID or yaml file with an expiration date that has not past and verify the user sees the Try Again page

[zachmargolis]

I might rename this to make it a little clearer what's being checked?

Suggested change

	validate :expired?
	validate :state_id_expiration?

[aduth]

Adding on to this comment:

• The method doesn't return a boolean, so I wouldn't expect a ? suffix
• Most of our "validate" methods are prefixed with validate_

Suggested change

	validate :expired?
	validate :validate_state_id_expiration

[zachmargolis]

I just realized this is the same regex as DateParser::AMERICAN_REGEX, maybe we could reuse that code here?

Suggested change

	['dob', 'state_id_expiration'].each do |dt|
	if (m = data.dig('document', dt).to_s.
	match(%r{(?<month>\d{1,2})/(?<day>\d{1,2})/(?<year>\d{4})}))
	data['document'][dt] =
	Date.new(m[:year].to_i, m[:month].to_i, m[:day].to_i)
	end
	end
	%w[dob state_id_expiration].each do |date_key|
	if (date_s = data.dig('document', date_key'))
	data['document'][date_key] = DateParser.parse_legacy(date_s)
	end
	rescue Date::Error
	# maybe don't rescue so we get the error?
	end

[theabrad]

LGTM. Tested locally with a yml file that had an expired ID and was sent to the "Try again" page.

[jmax-gsa]

LGTM

[jmax-gsa]

Hah! I just got done writing a very similar code block here independently while working on LG-13517. I think our PRs are going to mesh nicely. Excellent.