Skip to content

Analytics: Compact event properties #10987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 11 commits into from
Aug 9, 2024
Merged

Analytics: Compact event properties #10987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
373de61
Analytics: Compact event properties
aduth Jul 26, 2024
1c2d610
Remove redundant compact from AnalyticsEvents
aduth Jul 26, 2024
7d7476e
Remove nil value assertions for have_logged_event
aduth Jul 26, 2024
183f005
Recreate compact behavior in FakeAnaytics
aduth Jul 26, 2024
72d71dc
Remove nil analytics properties in memoized variables
aduth Jul 31, 2024
8e3720b
Handle compacted value exclusion on shared examples
aduth Aug 1, 2024
19a5447
Remove sneaky nil values behind anything / variable
aduth Aug 1, 2024
4aece67
Add allowed_extra_analytics for newly-flagged issues
aduth Aug 1, 2024
355b8bc
Handle inconsistently nil values
aduth Aug 1, 2024
384beb2
Restore nested nil values for reCAPTCHA result
aduth Aug 1, 2024
d815f0a
Fix timestamp platform precision mismatch
aduth Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/services/analytics.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def track_event(event, attributes = {})
attributes.delete(:pii_like_keypaths)
update_session_events_and_paths_visited_for_analytics(event) if attributes[:success] != false
analytics_hash = {
event_properties: attributes.except(:user_id),
event_properties: attributes.except(:user_id).compact,
new_event: first_event_this_session?,
path: request&.path,
session_duration: session_duration,
Expand Down
Loading