Document all analytics logged through sign_in_spec

spec/controllers/two_factor_authentication/personal_key_verification_controller_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
-RSpec.describe TwoFactorAuthentication::PersonalKeyVerificationController,
-               allowed_extra_analytics: [:*] do
+RSpec.describe TwoFactorAuthentication::PersonalKeyVerificationController do
   let(:personal_key) { { personal_key: 'foo' } }
   let(:payload) { { personal_key_form: personal_key } }
 

spec/controllers/users/passwords_controller_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.describe Users::PasswordsController, allowed_extra_analytics: [:*] do
+RSpec.describe Users::PasswordsController do
   context 'user visits edit password page' do
     let(:user) { create(:user) }
     before do

spec/features/account_email_language_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.describe 'Account email language', allowed_extra_analytics: [:*] do
+RSpec.describe 'Account email language' do
   let(:user) { user_with_2fa }
 
   let(:original_email_language) { 'es' }

spec/features/event_disavowal_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.feature 'disavowing an action', allowed_extra_analytics: [:*] do
+RSpec.feature 'disavowing an action' do
   let(:user) { create(:user, :fully_registered, :with_personal_key) }
 
   context 'with aggregated sign-in notifications enabled' do

spec/features/idv/doc_auth/agreement_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.feature 'agreement step error checking', allowed_extra_analytics: [:*] do
+RSpec.feature 'agreement step error checking' do
   include DocAuthHelper
   context 'skipping hybrid_handoff step', :js, driver: :headless_chrome_mobile do
     let(:fake_analytics) { FakeAnalytics.new }

spec/features/idv/doc_auth/welcome_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.feature 'welcome step', allowed_extra_analytics: [:*] do
+RSpec.feature 'welcome step' do
   include IdvHelper
   include DocAuthHelper
 

spec/features/idv/pending_profile_password_reset_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.describe 'Resetting password with a pending profile', allowed_extra_analytics: [:*] do
+RSpec.describe 'Resetting password with a pending profile' do
   include OidcAuthHelper
 
   let(:sp_name) { 'Test SP' }

spec/features/legacy_passwords_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.feature 'legacy passwords', allowed_extra_analytics: [:*] do
+RSpec.feature 'legacy passwords' do
   scenario 'signing in with a password digested by the uak verifier updates the digest' do
     user = create(:user, :fully_registered)
     user.update!(

spec/features/two_factor_authentication/multiple_tabs_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
-RSpec.feature 'user interacts with 2FA across multiple browser tabs',
-              allowed_extra_analytics: [:*] do
+RSpec.feature 'user interacts with 2FA across multiple browser tabs' do
   include SpAuthHelper
   include SamlAuthHelper
 

spec/features/two_factor_authentication/sign_in_via_personal_key_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.feature 'Signing in via one-time use personal key', allowed_extra_analytics: [:*] do
+RSpec.feature 'Signing in via one-time use personal key' do
   it 'destroys old key, does not offer new one' do
     user = create(
       :user, :fully_registered, :with_phone, :with_personal_key,

spec/features/users/sign_in_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.feature 'Sign in', allowed_extra_analytics: [:*] do
+RSpec.feature 'Sign in' do
   include SessionTimeoutWarningHelper
   include ActionView::Helpers::DateHelper
   include PersonalKeyHelper

spec/features/users/user_edit_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.feature 'User edit', allowed_extra_analytics: [:*] do
+RSpec.feature 'User edit' do
   let(:user) { create(:user, :fully_registered) }
 
   context 'editing password' do

spec/features/visitors/i18n_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.feature 'Internationalization', allowed_extra_analytics: [:*] do
+RSpec.feature 'Internationalization' do
   context 'visit homepage with no locale set' do
     it 'displays a header in the default locale' do
       visit root_path

spec/forms/idv/api_image_upload_form_spec.rb

@@ -528,6 +528,8 @@
           extra: {
             pii_like_keypaths: pii_like_keypaths,
             attention_with_barcode: false,
+            id_issued_status: 'missing',
+            id_expiration_status: 'missing',
           },
         )
       end