Merged
Conversation
changelog: Internal, Dependencies, Update dependencies to resolve security advisories
mitchellhenke
approved these changes
Jul 17, 2024
Contributor
Author
|
Based on the failing spec, it looks like this version update changed an expected behavior with how AAMVA requests are generated. It's only the difference of a newline character, but I'm going to take a closer look. |
Since we use it in our code, it should be an explicit dependency See: https://github.com/18F/identity-idp/blob/ea8a6081961d6c373a870dd5fea31efce89fde7e/app/services/proofing/aamva/request/verification_request.rb#L60-L102
Likely a result of ruby/rexml#164
Contributor
|
Wonder if it was ruby/rexml#164? |
Contributor
Author
The release notes include a number of changes unrelated to the specific security fix. I think the change here is a result of ruby/rexml#164 . I pushed a sync-up to the fixture file in 0493eb0. I also added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates
rexmlto resolve a security advisory.📜 Testing Plan
make audit