Skip to content

Split utilities stylesheet to standalone file #10946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 2 commits into from
Jul 17, 2024
Merged

Split utilities stylesheet to standalone file #10946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f484fd
Split utilities stylesheet to standalone file
aduth Jul 16, 2024
646c699
Fix typos on utilities stylesheet
aduth Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ lint_asset_bundle_size: ## Lints JavaScript and CSS compiled bundle size
@# and you have no options to split that from the common bundles. If you need to increase this
@# budget and accept the fact that this will force end-users to endure longer load times, you
@# should set the new budget to within a few thousand bytes of the production-compiled size.
find app/assets/builds/application.css -size -185000c | grep .
find app/assets/builds/application.css -size -105000c | grep .
find public/packs/application-*.digested.js -size -5000c | grep .

lint_migrations:
Expand Down
2 changes: 0 additions & 2 deletions app/assets/stylesheets/application.css.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,3 @@
@forward 'uswds';
@forward 'design-system-waiting-room';
@forward 'components';
@forward 'uswds-utilities';
@forward 'utilities';
3 changes: 3 additions & 0 deletions app/assets/stylesheets/utilities.css.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
@forward 'uswds-core';
@forward 'uswds-utilities';
@forward 'utilities';
3 changes: 2 additions & 1 deletion app/views/layouts/base.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@
<% end %>
<%= preload_link_tag font_path('public-sans/PublicSans-Bold.woff2') %>
<%= preload_link_tag font_path('public-sans/PublicSans-Regular.woff2') %>
<%= render_stylesheet_once_tags %>
<%= stylesheet_link_tag 'application', nopush: false %>
<%= render_stylesheet_once_tags %>
<%= stylesheet_link_tag 'utilities', nopush: false %>
<%= stylesheet_link_tag 'print', media: :print, preload_links_header: false %>
<%= csrf_meta_tags %>

Expand Down
3 changes: 2 additions & 1 deletion app/views/layouts/component_preview.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
<html>
<head>
<title>Component Preview</title>
<%= stylesheet_link_tag 'application', nopush: false %>
<%= render_stylesheet_once_tags %>
<%= stylesheet_link_tag 'application', media: 'all' %>
<%= stylesheet_link_tag 'utilities', nopush: false %>
</head>
<body class="height-auto padding-2 <%= params.dig(:lookbook, :display, :body_class) %>">
<% if params.dig(:lookbook, :display, :form) == true %>
Expand Down
3 changes: 2 additions & 1 deletion app/views/saml_idp/shared/saml_post_binding.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
document.documentElement.classList.replace('no-js', 'js');
<% end %>
<%= csrf_meta_tags %>
<%= stylesheet_link_tag 'application', media: 'all' %>
<%= stylesheet_link_tag 'application', nopush: false %>
<%= render_stylesheet_once_tags %>
<%= stylesheet_link_tag 'utilities', nopush: false %>
</head>
<body>
<div class="grid-container tablet:padding-y-6 no-js">
Expand Down