Use improved PKI service test stub consistently#10942
Merged
Conversation
jmax-gsa
approved these changes
Jul 16, 2024
Contributor
jmax-gsa
left a comment
jmax-gsa
left a comment
There was a problem hiding this comment.
That cleaned up nicely. It looks like the only remaining bit of magic is follow_piv_cac_redirect, and even that's pretty benign.
LGTM
jmhooper
approved these changes
Jul 16, 2024
changelog: Internal, Automated Testing, Use improved PKI service test stub consistently
aduth
force-pushed
the
aduth-rm-visit-piv-cac-service
branch
from
921176a to
ea9e714
Compare
mitchellhenke
pushed a commit
that referenced
this pull request
Jul 31, 2024
changelog: Internal, Automated Testing, Use improved PKI service test stub consistently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Supports LG-13477 (#10918)
🛠 Summary of changes
Builds upon the changes in #10939 to use the new
stub_piv_cac_serviceenhancements consistently throughout existing specs, removing thevisit_piv_cac_servicemethod and related spec helpers.As mentioned in #10939, the goal is to have this behave more realistically to the live implementation, and to have the tests interact with the page in the same way a user would. Previously, we relied heavily on visiting specific URLs that don't necessarily follow from interactions on the page.
📜 Testing Plan
Verify build passes.