Merged
Conversation
changelog: Bug Fixes, OpenID Connect, Fix language selection on OpenID Connect logout page
mitchellhenke
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Fixes an issue where trying to change the language on the OpenID Connect logout confirmation screen results in a 404 page, by allowing the pages to be localizable (within the
:localeblock in theroutes.rbfile).The only other routes defined out side the
:localeblock are not meant to be human-facing.📜 Testing Plan
Before: You'd see a 404
After: You see the page translated in the language you're expecting
Verify there are no regressions in other places which reference these URLs.
Example: http://localhost:3000/.well-known/openid-configuration
👀 Screenshots