Skip to content

Allow OIDC routes to be localizable#10941

Merged
aduth merged 1 commit intomainfrom
aduth-oidc-routes-localized
Jul 17, 2024
Merged

Allow OIDC routes to be localizable#10941
aduth merged 1 commit intomainfrom
aduth-oidc-routes-localized

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jul 16, 2024

🛠 Summary of changes

Fixes an issue where trying to change the language on the OpenID Connect logout confirmation screen results in a 404 page, by allowing the pages to be localizable (within the :locale block in the routes.rb file).

The only other routes defined out side the :locale block are not meant to be human-facing.

📜 Testing Plan

  1. Prerequisite: Have the OIDC sample application running in a separate process
  2. Visit http://localhost:9292
  3. Click "Sign in"
  4. Complete sign-in
  5. At SP, click "Sign out"
  6. Observe OIDC logout screen
  7. Change language of the page using the language selector

Before: You'd see a 404
After: You see the page translated in the language you're expecting

Verify there are no regressions in other places which reference these URLs.

Example: http://localhost:3000/.well-known/openid-configuration

👀 Screenshots

Before After
image image

changelog: Bug Fixes, OpenID Connect, Fix language selection on OpenID Connect logout page
@aduth aduth requested a review from mitchellhenke July 16, 2024 12:11
@aduth aduth merged commit ea8a608 into main Jul 17, 2024
@aduth aduth deleted the aduth-oidc-routes-localized branch July 17, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants