Support more formats for translation of Post Office hours#10925
Merged
mitchellhenke merged 1 commit intomainfrom Jul 15, 2024
Merged
Support more formats for translation of Post Office hours#10925mitchellhenke merged 1 commit intomainfrom
mitchellhenke merged 1 commit intomainfrom
Conversation
mitchellhenke
requested review from
a team,
gina-yamada and
solipet
and removed request for
a team and
solipet
Contributor
|
@mitchellhenke I was going to ask about adding an additional check for endash. It looks like there is a spec #selected_location_hours and thought you could just modify spec easily to test both hyphens and endash. What do you think? Non-blocking (only a suggestion to show both ultimately get set to endash) so will approve now. Update to spec to test: Also, I saw this was pulled out. Was it only because of messy conflict or did the reverted PR cause trouble? I am asking because I am thinking about if breaking- how can I test this even more? Confirmed places where ReadyToVerifyPresenter was being used
|
gina-yamada
approved these changes
Jul 10, 2024
changelog: Upcoming Features, In-Person Proofing, Support more formats for translation of Post Office hours
mitchellhenke
force-pushed
the
mitchellhenke/translate-post-office-v2-part-1
branch
2 times, most recently
from
a8d6aa2 to
3f15f97
Compare
Contributor
Author
|
@gina-yamada I think I'll tackle that in the next set of changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This is a follow-up to the reversion in #10882 and #10912 to do it in two stages. This change adds support so the ReadyToVerifyPresenter can handle either hyphens or endash prior to making the changes that will do that.