Merged
Conversation
This commit adds a `VerifyByMailConcern` to the IdP. This is intended to function as a mixin that wraps up the logic required for verify-by-mail. This includes: - Creating an providing an accessor for the verify-by-mail policy object - Delegating some methods to the policy object to describe things such as whether a user can request or resend a letter - Logging analytics events and computing analytics properties Inspiration from this came from this comment: https://github.com/18F/identity-idp/pull/10878/files#r1657358020 [skip changelog]
zachmargolis
approved these changes
Jun 27, 2024
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, bonus points for a spec for this new concern! might have to stub out a lot of methods but would be good for regressions
n1zyy
approved these changes
Jun 27, 2024
Contributor
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
Nice, I hadn't seen some of these opportunities in my story but this cleans things up nicely!
zachmargolis
approved these changes
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a
VerifyByMailConcernto the IdP. This is intended to function as a mixin that wraps up the logic required for verify-by-mail. This includes:Inspiration from this came from this comment: https://github.com/18F/identity-idp/pull/10878/files#r1657358020