Skip to content

Deploy RC 391.1 to Production #10855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajfarkas merged 1 commit into from
Jun 24, 2024
Merged

Deploy RC 391.1 to Production #10855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/jobs/reports/drop_off_report.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def perform(report_date)
self.report_date = report_date

subject = "Drop Off Report - #{report_date.to_date}"
JSON.parse(configs).each do |config|
configs.each do |config|
reports = [report_maker(config['issuers']).as_emailable_reports]
config['emails'].each do |email|
ReportMailer.tables_report(
Expand Down
1 change: 1 addition & 0 deletions lib/identity_config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ def self.store
Identity::Hostdata.config
end

# identity-hostdata transforms these configs to the described type
# rubocop:disable Metrics/BlockLength
BUILDER = proc do |config|
# ______________________________________
Expand Down
5 changes: 3 additions & 2 deletions spec/jobs/reports/drop_off_report_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@

RSpec.describe Reports::DropOffReport do
let(:report_date) { Date.new(2023, 12, 12).in_time_zone('UTC') }
# This is in S3 as a string that gets parsed via identity_config.rb
let(:report_config) do
'[{"emails":["ursula@example.com"],
"issuers":"urn:gov:gsa:openidconnect.profiles:sp:sso:agency_name:app_name"}]'
JSON.parse '[{"emails":["ursula@example.com"],
"issuers":["urn:gov:gsa:openidconnect.profiles:sp:sso:agency_name:app_name"]}]'
end

before do
Expand Down