-
Notifications
You must be signed in to change notification settings - Fork 166
LG-13289: Document parameters for verify proofing results event #10849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6bf5a4d
Document parameters for verify proofing results event
matthinz dd9c8f6
Use dots to separate nested option keys
matthinz 6dfca47
Apply .compact before logging
matthinz 53cf4c6
Analytics: remove nil args from happy hybrid path
matthinz cbd363f
Analytics: remove nil args from happy path
matthinz 5293314
Analytics: Remove nil args from gpo path test
matthinz 9009848
Analytics: Remove nil args from in person test
matthinz 018a219
Analytics: Remove nil args from happy selfie tests
matthinz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT of trying to update https://github.com/18F/identity-idp/blob/main/spec/support/fake_analytics.rb#L73 to work with nested hashes/analytics like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I understand that code enough to do it in this PR. Honestly, it starts to feel to me like we need a typechecker. I kind of wonder if it would be preferable to log flat, un-nested structures?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At that point we should switch to Crystal!