Skip to content

Move dependency audit checks into own task in Gitlab CI #10814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachmargolis merged 3 commits into from
Jun 13, 2024
Merged

Move dependency audit checks into own task in Gitlab CI #10814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8928221
Move dependency audit checks into own task in Gitlab CI
zachmargolis Jun 13, 2024
bf82eda
Update .gitlab-ci.yml
zachmargolis Jun 13, 2024
3929497
Add "needs" clause for pinpoint-check job too
zachmargolis Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,8 @@ js_tests:
- yarn test

pinpoint-check:
needs:
- job: install
stage: test
cache:
- <<: *ruby_cache
Expand All @@ -328,6 +330,18 @@ pinpoint-check:
- *yarn_install
- make lint_country_dialing_codes

audit_packages:
Comment thread
zachmargolis marked this conversation as resolved.
needs:
- job: install
stage: test
cache:
- <<: *ruby_cache
- <<: *yarn_cache
script:
- *bundle_install
- *yarn_install
- make audit

prepare_deploy:
# Runs in parallel with tests so we can deploy more quickly after passing
stage: test
Expand Down
11 changes: 7 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ ARTIFACT_DESTINATION_FILE ?= ./tmp/idp.tar.gz

.PHONY: \
analytics_events \
audit \
brakeman \
build_artifact \
check \
Expand Down Expand Up @@ -74,11 +75,7 @@ endif
make lint_analytics_events_sorted
@echo "--- brakeman ---"
make brakeman
@echo "--- bundler-audit ---"
bundle exec bundler-audit check --update
# JavaScript
@echo "--- yarn audit ---"
yarn audit --groups dependencies; test $$? -le 7
@echo "--- eslint ---"
yarn run lint
@echo "--- typescript ---"
Expand All @@ -105,6 +102,12 @@ endif
@echo "--- lint migrations ---"
make lint_migrations

audit: ## Checks packages for vulnerabilities
@echo "--- bundler-audit ---"
bundle exec bundler-audit check --update
@echo "--- yarn audit ---"
yarn audit --groups dependencies; test $$? -le 7

lint_erb: ## Lints ERB files
bundle exec erblint app/views app/components

Expand Down