Document critical-path MFA setup analytics methods#10777
Merged
Conversation
changelog: Internal, Analytics, Document critical-path MFA setup analytics methods
mitchellhenke
approved these changes
Jun 7, 2024
brandemix
pushed a commit
to brandemix/18F-identity-idp
that referenced
this pull request
Jun 17, 2024
* Document critical-path MFA setup analytics methods changelog: Internal, Analytics, Document critical-path MFA setup analytics methods * Fix capitalization on param YARDoc * Remove unnecessary allowed_extra_analytics * Fix spec assertions, document TOTP properties * Remove unnecessary allowed_extra_analytics * Fix spec assertions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This documents a few more analytics methods, intended to address low-hanging fruit of common analytics logged during account creation:
multi_factor_auth_setupmulti_factor_auth_added_phonemulti_factor_auth_added_totpThis is similar in purpose to #10736, where #10736 addressed common analytics during sign-in.
Why?
📜 Testing Plan
Verify build passes. This should not have any impact on user-facing behavior.