Skip to content

Validate unnecessary exempted files in TypeScript enforcement #10760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 2 commits into from
Jun 4, 2024
Merged

Validate unnecessary exempted files in TypeScript enforcement #10760

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
458ca86
Validate unnecessary exempted files in TypeScript enforcement
aduth Jun 4, 2024
75e3d43
Remove unnecessary array splat
aduth Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions scripts/enforce-typescript-files.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ const LEGACY_FILE_EXCEPTIONS = [
'spec/javascript/packages/document-capture/context/acuant-spec.jsx',
'spec/javascript/packages/document-capture/context/device-spec.jsx',
'spec/javascript/packages/document-capture/context/failed-capture-attempts-spec.jsx',
'spec/javascript/packages/document-capture/context/feature-flag-spec.jsx',
'spec/javascript/packages/document-capture/context/file-base64-cache-spec.js',
'spec/javascript/packages/document-capture/context/index-spec.js',
'spec/javascript/packages/document-capture/context/selfie-capture-spec.jsx',
Expand All @@ -83,15 +82,24 @@ const packagesWithEntrypoints = await glob('app/javascript/packages/*/package.js

const jsFiles = await glob(
['app/{javascript/packages,components}/**/*.{js,jsx}', 'spec/javascript/*/**/*.{js,jsx}'],
{
ignore: [...packagesWithEntrypoints.map((path) => join(path, '**')), ...LEGACY_FILE_EXCEPTIONS],
},
{ ignore: packagesWithEntrypoints.map((path) => join(path, '**')) },
);

const invalidExceptions = LEGACY_FILE_EXCEPTIONS.filter((file) => !jsFiles.includes(file));

assert(
!invalidExceptions.length,
`Unnecessary exception should be removed from LEGACY_FILE_EXCEPTIONS allowlist.

Found ${JSON.stringify(invalidExceptions)}`,
);

const unexpectedJSFiles = jsFiles.filter((file) => !LEGACY_FILE_EXCEPTIONS.includes(file));

assert(
!jsFiles.length,
!unexpectedJSFiles.length,
`All new JavaScript files should be written with TypeScript extensions (.ts, .tsx).

Found ${JSON.stringify(jsFiles)}
Found ${JSON.stringify(unexpectedJSFiles)}
`,
);